[ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

[Shashank Ram]

Sounds good Alin, I will update the documentation, and we can work on a patch with the solution you suggested as an alternative workflow.

Thanks,
Shashank

________________________________________
From: Alin Serdean <aserdean at cloudbasesolutions.com>
Sent: Tuesday, February 27, 2018 9:38:22 AM
To: Shashank Ram; Alin Balutoiu; Anand Kumar; dev at openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

Let's have both 😊.

@Shashank Ram can you please update the documentation
to accommodate for the new `vstudiotargetver` option.

Thanks,
Alin.

-----Mesaj original-----
De la: Shashank Ram [mailto:rams at vmware.com]
Trimis: Tuesday, February 20, 2018 7:29 PM
Către: Alin Balutoiu <abalutoiu at cloudbasesolutions.com>; Anand Kumar <kumaranand at vmware.com>; Alin Serdean <aserdean at cloudbasesolutions.com>; dev at openvswitch.org
Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

That is not consistent with how we specify the Debug/Release flag. There is no need to do the whole configure if you specify the targets correctly. Running multiple make commands is confusing for the user in terms of the current workflow.

Thanks,
Shashank

________________________________________
From: Alin Balutoiu <abalutoiu at cloudbasesolutions.com>
Sent: Tuesday, February 20, 2018 2:58:06 AM
To: Anand Kumar; Shashank Ram; Alin Serdean; dev at openvswitch.org
Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively compile targets

I agree with having the target specified during make and not during configure.

There is no reason to re-do the whole configure process (as Alin mentioned that it is particularly slow on Windows) only to change the target version.



Thanks,

Alin Balutoiu



> -----Original Message-----

> From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-

> bounces at openvswitch.org] On Behalf Of Anand Kumar

> Sent: Tuesday, February 13, 2018 6:34 AM

> To: Shashank Ram <rams at vmware.com>; Alin Serdean

> <aserdean at cloudbasesolutions.com>; dev at openvswitch.org

> Subject: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively

> compile targets

>

> Hi,

>

> My thoughts are with Shashank on this, it makes sense to have 1 configure and 1

> make command to build a particular target, instead of having flexibility to

> specify multiple targets.

>

> Thanks,

> Anand Kumar

>

> On 2/8/18, 10:56 AM, "ovs-dev-bounces at openvswitch.org on behalf of

> Shashank Ram" <ovs-dev-bounces at openvswitch.org on behalf of

> rams at vmware.com> wrote:

>

>

>

>

>

>     ________________________________________

>     From: aserdean at ovn.org <aserdean at ovn.org>

>     Sent: Thursday, February 8, 2018 10:43 AM

>     To: Shashank Ram; aserdean at ovn.org; dev at openvswitch.org

>     Subject: RE: [ovs-dev] [PATCH] datapath-windows: Support to selectively

> compile targets

>

>     Trimming the message a bit.

>

>     -----Mesaj original-----

>     De la: ovs-dev-bounces at openvswitch.org

>     [mailto:ovs-dev-bounces at openvswitch.org] În numele Shashank Ram

>     Trimis: Thursday, February 8, 2018 7:50 PM

>     Către: aserdean at ovn.org; dev at openvswitch.org

>     Subiect: Re: [ovs-dev] [PATCH] datapath-windows: Support to selectively

>     compile targets

>

>     Hi Alin, thanks for the review.

>     I personally feel we should be consistent and run configure, and have a

>     single make command to build both user space and kernel. What part did you

>     find complicated?

>     [Alin Serdean] I.e. if I configure to target 8. And after I need to target

>     10 I need to do a reconfigure (similar, for debug and or other platforms).

>     [SR]: In an automated environment, this shouldn't happen.

>     For local compilation, you should be able to manually compile the kernel.

>

>     The configure part is particularly slow on Windows.

>     For convenience the old part with selecting Debug/Release and

>     trying to build for all the compilers found in the system is still there, so

>     building both

>     userspace and kernel will still be in a single command.

>     I don't see a huge issue to specify two or more make commands to build a

>     particular target of the kernel

>     via the shell.

>     [SR]: I don't think its a big deal either, but its more convenient to run 1

> configure and 1

>     make command.

>

>     I prefer to keep this as is for now and wait for more reviews.

>

>     _______________________________________________

>     dev mailing list

>     dev at openvswitch.org

>     https://urldefense.proofpoint.com/v2/url?u=https-

> 3A__mail.openvswitch.org_mailman_listinfo_ovs-

> 2Ddev&d=DwIFBA&c=uilaK90D4TOVoH58JNXRgQ&r=Q5z9tBe-

> nAOpE7LIHSPV8uy5-

> 437agMXvkeHHMkR8Us&m=fKK6KZRD0tZEfwHzLhMsabCH5aXzzYiRP-

> pJR20Xj9o&s=nEl_7Q-LhJ74AdsiY85DjA-kWy0uESr5DyFrWDQYKjs&e=

>

>

> _______________________________________________

> dev mailing list

> dev at openvswitch.org

> https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=6OuVHk-mnufSWzkKa74UkQ&m=0mrz2IZApdtvtjOTZbZRQCPxRCib7Tbkwj_B20vv1cI&s=NXY8REuxaZfNEMFuCbcesEoSMUjNza2Xyn8D6O7NamE&e=