[ovs-dev] [shadow 0/8] Remove shadowed declarations

[Justin Pettit]

The first eight patches in this series remove shadow declarations.  I
don't believe this series fixes any bugs, but we have had bugs
introduced by shadow declarations in the past.  The final patch adds the
"-Wshadow" flag to supported compilers by default.


Justin Pettit (8):
  Don't shadow global VLOG "rl" definition.
  cmap: Allow CMAP_FOR_EACH to be nested without shadowing variables.
  dp-packet: Add index to DP_PACKET_BATCH_FOR_EACH to prevent shadowing.
  Don't shadow iterator values.
  db-ctl-base: Don't shadow 'invalidate_cache' callback.
  ovs-numa: Prevent shadowing 'dummy_config'.
  Don't shadow variables.
  Add -Wshadow for compilers that support it.

 configure.ac                  |  1 +
 lib/cmap.h                    | 15 ++++++++--
 lib/conntrack.c               |  2 +-
 lib/daemon-unix.c             | 62 ++++++++++++++++++++---------------------
 lib/db-ctl-base.c             |  8 +++---
 lib/db-ctl-base.h             |  2 +-
 lib/dp-packet.h               | 16 +++++------
 lib/dpif-netdev.c             | 28 +++++++++----------
 lib/netdev-dpdk.c             |  2 +-
 lib/netdev-dummy.c            |  2 +-
 lib/netdev-linux.c            | 12 ++++----
 lib/netdev.c                  |  2 +-
 lib/nx-match.c                |  5 ++--
 lib/odp-execute.c             | 26 ++++++++---------
 lib/ofp-actions.c             | 18 ++++++------
 lib/ofp-port.c                |  4 +--
 lib/ovs-numa.c                | 34 +++++++---------------
 lib/ovs-numa.h                |  2 +-
 lib/route-table.c             |  9 +++---
 ofproto/connmgr.c             |  4 +--
 ofproto/ofproto-dpif-upcall.c | 65 ++++++++++++++++++++-----------------------
 ofproto/ofproto-dpif.c        | 14 ++++------
 ofproto/ofproto.c             |  4 +--
 ovn/controller/ofctrl.c       | 12 ++++----
 ovn/controller/pinctrl.c      | 10 +++----
 ovn/northd/ovn-northd.c       |  8 +++---
 tests/test-classifier.c       |  4 +--
 tests/test-conntrack.c        | 20 ++++++-------
 utilities/ovs-ofctl.c         | 24 ++++++++--------
 29 files changed, 201 insertions(+), 214 deletions(-)

-- 
2.7.4