[ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Matteo Croce mcroce at redhat.com
Tue Jan 2 17:18:03 UTC 2018


On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole <aconole at redhat.com> wrote:
> Hi Matteo,
>
> Matteo Croce <mcroce at redhat.com> writes:
>
>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py
>> to populate the field with the right value.
>>
>> Signed-off-by: Matteo Croce <mcroce at redhat.com>
>> ---
>
> Sorry I missed some of the development for this - I think it's better to
> have the dpdk version retrieved via an appctl command.  I can't think of
> a need for this information to be persistent - if it's for historical
> information when debugging, we can put it in with the logs when dpdk is
> started.  The user cannot influence DPDK version dynamically - it is not
> just read-only, but it's read-only from a compile time decision.  I
> might be misunderstanding the point of putting this in the DB, though?

Hi Aaron,

I was threating dpdk_version the same way as ovs_version.
ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
What about putting it only in `ovs-vswitchd --version` output and not
into the DB?

-- 
Matteo Croce
per aspera ad upstream


More information about the dev mailing list