[ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

[Ben Pfaff]

On Tue, Jan 02, 2018 at 08:13:12AM +0000, Jan Scheurich wrote:
> > -----Original Message-----
> > From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org] On Behalf Of SatyaValli
> > Sent: Monday, 01 January, 2018 11:59
> > To: dev at openvswitch.org
> > Cc: Manasa Cherukupally <manasa.cherukupally at tcs.com>; Surya Muttamsetty <muttamsetty.surya at tcs.com>; Pavani Panthagada
> > <p.pavani1 at tcs.com>; SatyaValli <satyavalli.rama at tcs.com>; Lavanya Harivelam <harivelam.lavanya at tcs.com>
> > Subject: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support
> > 
> > From: SatyaValli <satyavalli.rama at tcs.com>
> > 
> > This Patch provides implementation Existing flow entry statistics are
> > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > as Flow Description.
> > 
> > To support this implementation below messages are newly added
> > 
> > OFPRAW_OFPT15_FLOW_REMOVED,
> > OFPRAW_OFPST15_FLOW_REQUEST,
> > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > OFPRAW_OFPST15_FLOW_REPLY,
> > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > 
> > The current commit adds support for the new feature in flow statistics
> > multipart messages,aggregate multipart messages and OXS support for flow
> > removal message, individual flow description messages.
> > 
> > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS fields
> > for displaying the desired flow stats.
> > 
> > Below are Commands to display OXS stats field wise
> > 
> > Flow Statistics Multipart
> > ovs-ofctl dump-flows -O OpenFlow15 <bridge> idle_time
> > ovs-ofctl dump-flows -O OpenFlow15 <bridge> packet_count
> > ovs-ofctl dump-flows -O OpenFlow15 <bridge> byte_count
> 
> This would break backward compatibility for one of the most frequently used OVS CLI commands. Why don't you introduce a new command such as "ovs-ofctl dump-flow-stats" for the new OXS stats?

I think you might be misinterpreting the meaning here.  It doesn't
appear to break compatibility, at least not in a major way, since it
doesn't do a lot of updates to the tests that would otherwise be
required.