[ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

[Gregory Rose]

On 1/2/2018 11:42 AM, Justin Pettit wrote:
>> On Dec 28, 2017, at 3:22 PM, Gregory Rose <gvrose8192 at gmail.com> wrote:
>>
>> SFAICT it emulates exactly what the system-traffic.at test 001 does.  And it works fine... /shrug.
>>
>> What distribution, kernel, etc are you using for your check-kmod testing?  I'll try to emulate that
>> exactly and then see if I can get similar results.
> I'm using Ubuntu 16.04 with kernel 4.4.0-104-generic.  I sent you a link on our Slack channel to the internal tester that runs different OSs.  It fails a few of tests, but they're the same ones that fail on master.  (We need to address those, but they shouldn't be related to my patches.)
>
> --Justin
>
>

Justin,

I have done more testing last night and this morning and have a couple 
of findings.

First, the tests themselves *all* succeed.  However, they are marked as 
failed because of warnings that
occur during OVS_TRAFFIC_VSWITCHD_STOP in system-traffic.at.  If I 
comment out
OVS_TRAFFIC_VSWITCHD_STOP then the test runs successfully.

AT_SETUP([datapath - ping between two ports])
OVS_TRAFFIC_VSWITCHD_START()

AT_CHECK([ovs-ofctl add-flow br0 "actions=normal"])

ADD_NAMESPACES(at_ns0, at_ns1)

ADD_VETH(p0, at_ns0, br0, "10.1.1.1/24")
ADD_VETH(p1, at_ns1, br0, "10.1.1.2/24")

NS_CHECK_EXEC([at_ns0], [ping -q -c 3 -i 0.3 -w 2 10.1.1.2 | 
FORMAT_PING], [0], [dnl
3 packets transmitted, 3 received, 0% packet loss, time 0ms
])
NS_CHECK_EXEC([at_ns0], [ping -s 1600 -q -c 3 -i 0.3 -w 2 10.1.1.2 | 
FORMAT_PING], [0], [dnl
3 packets transmitted, 3 received, 0% packet loss, time 0ms
])
NS_CHECK_EXEC([at_ns0], [ping -s 3200 -q -c 3 -i 0.3 -w 2 10.1.1.2 | 
FORMAT_PING], [0], [dnl
3 packets transmitted, 3 received, 0% packet loss, time 0ms
])

dnl OVS_TRAFFIC_VSWITCHD_STOP
AT_CLEANUP

## ------------------------------ ##
## openvswitch 2.8.90 test suite. ##
## ------------------------------ ##
   1: datapath - ping between two ports               ok

## ------------- ##
## Test results. ##
## ------------- ##

1 test was successful.

I'm now debugging the OVS_TRAFFIC_VSWITCHD_STOP macro and trying to 
determine what
is causing the problem.  Here are the log messages:

2018-01-03T17:30:52.340Z|00039|netdev_linux|WARN|ovs-p1: removing 
policing failed: No such device
2018-01-03T17:30:52.341Z|00040|ofproto|WARN|br0: cannot get STP status 
on nonexistent port 2
2018-01-03T17:30:52.341Z|00041|ofproto|WARN|br0: cannot get RSTP status 
on nonexistent port 2
2018-01-03T17:30:52.343Z|00042|bridge|INFO|bridge br0: deleted interface 
ovs-p1 on port 2
2018-01-03T17:30:52.346Z|00043|bridge|WARN|could not open network device 
ovs-p1 (No such device)
2018-01-03T17:30:52.360Z|00044|bridge|INFO|bridge br0: deleted interface 
ovs-p0 on port 1
2018-01-03T17:30:52.364Z|00045|bridge|WARN|could not open network device 
ovs-p0 (No such device)
2018-01-03T17:30:52.367Z|00046|bridge|WARN|could not open network device 
ovs-p1 (No such device)

It is the WARNS from the OVS_TRAFFIC_VSWITCHD_STOP part of the test that 
are causing all tests to fail.

Again, I see this on multiple systems.  They are all VMs though so I'm 
wondering if the internal test that
you are referring to was run on bare metal?

Thanks,

- Greg