[ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

[Vishal Deep Ajmera]

Hi Matteo,

Can we also have DPDK version in the logs (VLOG_INFO) when DPDK is initialized ? May be in dpdk_init() function. This will help in identifying the correct DPDK version from the log files while debugging issues.

Warm Regards,
Vishal Ajmera

-----Original Message-----
From: ovs-dev-bounces at openvswitch.org [mailto:ovs-dev-bounces at openvswitch.org] On Behalf Of Aaron Conole
Sent: Wednesday, January 03, 2018 12:20 AM
To: Matteo Croce <mcroce at redhat.com>
Cc: dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] ovs-vsctl: show DPDK version

Matteo Croce <mcroce at redhat.com> writes:

> On Tue, Jan 2, 2018 at 6:08 PM, Aaron Conole <aconole at redhat.com> wrote:
>> Hi Matteo,
>>
>> Matteo Croce <mcroce at redhat.com> writes:
>>
>>> Show DPDK version if Open vSwitch is compiled with DPDK support.
>>> Add a `dpdk_version` column in the datamodel, change ovs-ctl and 
>>> ovs-dev.py to populate the field with the right value.
>>>
>>> Signed-off-by: Matteo Croce <mcroce at redhat.com>
>>> ---
>>
>> Sorry I missed some of the development for this - I think it's better 
>> to have the dpdk version retrieved via an appctl command.  I can't 
>> think of a need for this information to be persistent - if it's for 
>> historical information when debugging, we can put it in with the logs 
>> when dpdk is started.  The user cannot influence DPDK version 
>> dynamically - it is not just read-only, but it's read-only from a 
>> compile time decision.  I might be misunderstanding the point of putting this in the DB, though?
>
> Hi Aaron,
>
> I was threating dpdk_version the same way as ovs_version.

Ahh, okay.  I had forgotten that ovs_version (and other information) was in the db as well.  Sorry for that - next time I'll have coffee before reviewing. :)

> ovs_version is saved into the DB by ovs-ctl and it isn't read-only either.
> What about putting it only in `ovs-vswitchd --version` output and not 
> into the DB?

What about using the datapath_version field?  That field already gets populated, and I think it may be okay to modify the return value of dpif_netdev_get_datapath_version function when dpdk is enabled.  Just a thought.
_______________________________________________
dev mailing list
dev at openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev