[ovs-dev] [PATCH v6 3/4] nsh: fix nested mask for OVS_KEY_ATTR_NSH
Ben Pfaff
blp at ovn.org
Thu Jan 4 20:44:31 UTC 2018
On Fri, Dec 08, 2017 at 10:04:24PM +0800, Yi Yang wrote:
> NSH kernel implementation used nested mask for OVS_KEY_ATTR_NSH,
> so NSH userspace must adapt to it, OVS hasn't used nested mask for
> any key attribute so far, OVS_KEY_ATTR_NSH is the first use case.
>
> Signed-off-by: Yi Yang <yi.y.yang at intel.com>
checkpatch says:
ERROR: Inappropriate bracing around statement
#21 FILE: lib/odp-execute.c:284:
if (has_mask)
ERROR: Inappropriate bracing around statement
#23 FILE: lib/odp-execute.c:286:
else
WARNING: Line length is >79-characters long
#223 FILE: lib/odp-util.c:2507:
/* the attribute can have mask, len is 2 * expected_len for that case. */
I think these "sparse" warnings are new:
../lib/odp-util.c:4941:37: warning: incorrect type in argument 2 (different base types)
../lib/odp-util.c:4941:37: expected restricted ovs_be32 [usertype] *key
../lib/odp-util.c:4941:37: got unsigned int *<noident>
../lib/odp-util.c:4941:47: warning: incorrect type in argument 3 (different base types)
../lib/odp-util.c:4941:47: expected restricted ovs_be32 [usertype] *mask
../lib/odp-util.c:4941:47: got unsigned int *
Thanks,
Ben.
More information about the dev
mailing list