[ovs-dev] [patch v1 1/3] dpctl conntrack: Add get and set maxconns command.

[Darrell Ball]

On 1/4/18, 1:30 PM, "ovs-dev-bounces at openvswitch.org on behalf of Ben Pfaff" <ovs-dev-bounces at openvswitch.org on behalf of blp at ovn.org> wrote:

    On Mon, Dec 18, 2017 at 08:27:17AM -0800, Darrell Ball wrote:
    > Get and set dpctl commands are added for conntrack maxconns.
    > These commands are only supported in the userspace
    > datapath at this time.
    > 
    > Signed-off-by: Darrell Ball <dlu998 at gmail.com>
    > Signed-off-by: Antonio Fischetti <antonio.fischetti at intel.com>
    > Co-authored-by: Antonio Fischetti <antonio.fischetti at intel.com>
    
    Thanks for the patch!
    
    In conntrack_set_maxconns(), atomic_init() should only be used for
    initializing a fresh atomic variable.  Please use atomic_store() to
    modify an initialized atomic variable.

Sure; atomic_store() is certainly more correct api to use.
thanks
    
    Please mention the new feature in NEWS.

Sure, thanks
    
    Thanks,
    
    Ben.
    _______________________________________________
    dev mailing list
    dev at openvswitch.org
    https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=BVhFA09CGX7JQ5Ih-uZnsw&m=p_4QNkAN0L5a_kDiFkGK8jAbFKrfYFtauomJhzCIEZE&s=YtV8m77vUcEMOKLtU1gUQj-akFCuXmhKW6_l4Zwn0RE&e=