[ovs-dev] [PATCH] gre: strip gre-tso offload flags

[Gregory Rose]

On 12/28/2017 8:45 PM, wenxu at ucloud.cn wrote:
> From: wenxu <wenxu at ucloud.cn>
>
> if the gro enable, ipgre receive a gre-tso package. After pop
> the gre-tunnel the encapsulation and GSO_ENCAP flags should be
> striped. or the packet encap again and will be dropped in
> ovs_iptunnel_handle_offloads
>
> Signed-off-by: wenxu <wenxu at ucloud.cn>
> ---
>   datapath/linux/compat/ip_gre.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c
> index 03c5435..94fdaa9 100644
> --- a/datapath/linux/compat/ip_gre.c
> +++ b/datapath/linux/compat/ip_gre.c
> @@ -140,6 +140,8 @@ static int ipgre_rcv(struct sk_buff *skb, const struct tnl_ptk_info *tpi)
>   		__be64 tun_id;
>   		int err;
>   
> +		if (iptunnel_pull_offloads(skb))
> +			return PACKET_REJECT;
>   
>   		skb_pop_mac_header(skb);
>   		flags = tpi->flags & (TUNNEL_CSUM | TUNNEL_KEY);

Wenxu,

I see to patches in the dev list that appear to be identical but this 
one has the later timestamp so I'll
respond to this one.

The patch looks simple enough itself but can you explain how to trigger 
the bug so that I can test
this fix?

Thanks,

- Greg