[ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error path

Stokes, Ian ian.stokes at intel.com
Fri Jan 5 18:29:50 UTC 2018


> Subject: [ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error
> path

Hi Zhang,

Patch looks ok to me, validated on my setup. 2 minor knits.

I'd like to see an expanded commit message rather than just the subject header above.

> 
> From: zhangliping <zhangliping02 at baidu.com>
> 
> Signed-off-by: zhangliping <zhangliping02 at baidu.com>
Need to add a Fixes tag here, in this case it fixes commit 9509913a and usually cc the original author (in this case myself), there are examples of the of fixes tags in the git commit history you can follow.

Thanks
Ian
> ---
>  lib/netdev-dpdk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index
> 8f22264b3..a3eb3c720 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -2258,6 +2258,7 @@ netdev_dpdk_policer_construct(uint32_t rate,
> uint32_t burst)
>                                      &policer->app_srtcm_params);
>      if (err) {
>          VLOG_ERR("Could not create rte meter for ingress policer");
> +        free(policer);
>          return NULL;
>      }
> 
> --
> 2.13.4
> 
> 
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list