[ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

[Gregory Rose]

On 1/5/2018 10:46 AM, Justin Pettit wrote:
>> On Jan 5, 2018, at 8:05 AM, Gregory Rose <gvrose8192 at gmail.com> wrote:
>>
>> For now that's about as far as I can take my investigation since I have a few other things I need to work
>> on.  If you can think of another test I should run or something for me to check into let me know.
> Ben noticed that this seemed to have been removed in error in my patch:
>
>> @@ -813,7 +816,6 @@ recv_upcalls(struct handler *handler)
>>
>>          upcall->key = dupcall->key;
>>          upcall->key_len = dupcall->key_len;
>> -        upcall->ufid = &dupcall->ufid;
>>
>>          upcall->out_tun_key = dupcall->out_tun_key;
>>          upcall->actions = dupcall->actions;
>
> Can you try adding that line back and see if the problem goes away on your end?
>
> Thanks,
>
> --Justin
>
Justin,

That didn't seem to help.  The cookie->header.type is still equal to 
type USER_ACTION_COOKIE_UNSPEC
in the classify_upcall() function and that causes this message:

2018-01-05T19:12:09.957Z|00001|ofproto_dpif_upcall(handler1)|WARN|invalid 
user cookie of type 0 and size 4

- Greg