[ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

[Stokes, Ian]

> -----Original Message-----
> From: Markos Chandras [mailto:mchandras at suse.de]
> Sent: Tuesday, January 9, 2018 3:55 PM
> To: dev at openvswitch.org
> Cc: Kavanagh, Mark B <mark.b.kavanagh at intel.com>; Ilya Maximets
> <i.maximets at samsung.com>; Stokes, Ian <ian.stokes at intel.com>; Markos
> Chandras <mchandras at suse.de>
> Subject: [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t
> 
> From: Mark Kavanagh <mark.b.kavanagh at intel.com>
> 
> netdev_dpdk_detach() declares a 'port_id' variable, of type uint8_t.
> This variable should instead be of type dpdk_port_t.

Hi Markos, is there a specific reason you require this patch back ported to 2.8?

OVS 2.8 supports DPDK 17.05.2, looking at the prototype of the rte_eth_dev_detach() function in DPDK uint8_t is correct.

rte_eth_dev_detach(uint8_t port_id, char *name);

I would have thought this change is only required if using DPDK 17.11 which will be part of OVS 2.9. Maybe I've missed something.

Thanks
Ian
> 
> Fixes: bb37956ac ("netdev-dpdk: Use uint8_t for port_id.")
> CC: Ilya Maximets <i.maximets at samsung.com>
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
> Acked-by: Ilya Maximets <i.maximets at samsung.com>
> Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> Signed-off-by: Markos Chandras <mchandras at suse.de>
> ---
>  lib/netdev-dpdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index
> 41acb5b62..dc96d7ce3 100644
> --- a/lib/netdev-dpdk.c
> +++ b/lib/netdev-dpdk.c
> @@ -2521,7 +2521,7 @@ netdev_dpdk_detach(struct unixctl_conn *conn, int
> argc OVS_UNUSED,  {
>      int ret;
>      char *response;
> -    uint8_t port_id;
> +    dpdk_port_t port_id;
>      char devname[RTE_ETH_NAME_MAX_LEN];
>      struct netdev_dpdk *dev;
> 
> --
> 2.15.1