[ovs-dev] [PATCH branch-2.8] netdev-dpdk: replace uint8_t with dpdk_port_t

Ben Pfaff blp at ovn.org
Tue Jan 9 17:30:39 UTC 2018


On Tue, Jan 09, 2018 at 09:27:11AM -0800, Ben Pfaff wrote:
> On Tue, Jan 09, 2018 at 05:02:11PM +0000, Markos Chandras wrote:
> > Hi Ben,
> > 
> > On 09/01/18 16:56, Ben Pfaff wrote:
> > >> Sure, I was just concerned was it fixing a compilation issue or such for you. I've seen it's been applied already and I've given it a quick validation check without issue so no worries.
> > > 
> > > I interpreted your Signed-off-by as a request to apply it, but I think I
> > > must have misunderstood a backport of a patch already on master.  I
> > > won't apply it so quickly next time.  I'm learning here too :-)
> > > 
> > 
> > Oh should I have done something different to make it clear that it was a
> > backport? I simply took the patch from master, modified the Subject line
> > to indicate the branch for the backport and added my SoB line. Might be
> > better to use 'cherry-pick -x' for backports to make it more explicit. I
> > apologize for any confusion this may have caused
> 
> I think you did OK, I just wasn't paying attention carefully enough.

For what it's worth, one reason I didn't apply more scrutiny is that the
patch seemed harmless at worst.


More information about the dev mailing list