[ovs-dev] [PATCH] ovn-controller: Change duplicate flows trace from INFO to DBG

[Ben Pfaff]

On Tue, Jan 09, 2018 at 02:54:36PM +0100, Daniel Alvarez wrote:
> When ovn-controller detects that a flow is duplicated, it will print
> an INFO trace. Even though it's rate limited, this patch is changing
> the trace level back to DEBUG to reduce noise.
> 
> Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
> ---
> In our effort to ensure consistency across objects in Neutron and OVN
> databases we find some special cases like security group rules which
> match OVN ACLs but not in 1:1 relationship. Until now, two identical
> security group rules beloning each to a different security group would
> generate a single ACL in NB database. With this behavior, there's no
> way to map the ACL in OVN to the corresponding Neutron object.
> 
> By implementing [0] we're trying to ensure this mapping so we make use
> of the external_ids column of every table for this purpose. It may happen
> that we'll have two identical ACLs but each referencing a different
> Neutron object in their external_ids field. However, this will make
> ovn-controller to drop those duplicated flows and log a (rate controlled)
> INFO trace. In order to reduce this noise, this patch changes it to DBG.
> 
> [0] https://docs.openstack.org/networking-ovn/latest/contributor/design/database_consistency.html

This discussion "below the fold" is valuable, so I moved it into the
commit message, added a link to the ovs-dev discussion on this topic,
and applied this to master.  Thank you!