[ovs-dev] [PATCH v3 0/4] ovs-bugtool: Enahncing and refactoring the OVS-Bugtool.

Dávid Patrik Pintér david.patrik.pinter at ericsson.com
Wed Jan 10 10:36:49 UTC 2018


The development and maintenance of the OVS-Bugtool is long due. It completely ignores DPDK datapath-related logs and information, which are essential by troubleshooting OVS with DPDK datapath. There is also a wide set of none DPDK-related files and commands already used by the community but not integrated in the OVS-Bugtool. 

The main goal of this patch set is to refactor the OVS-Bugtool plugins and to extend the scope of the collected information. 

The following additions and refactoring are implemented in this patch set:
 - Adding more queries and files to the corresponding plugin xml files.
 - Applying a new query calling practice for the plugin files: single line queries called directly from xml, multiple line queries implemented in scripts and the script is called from the xml. The new practice improves the transparency of the plugin queries which is useful from maintenance point of view: developers don't need to open the scripts to understand the xml's intent, only for longer queries, where a single line representation would be hard to digest.
 - Implementing query repeat feature for traffic related querries.
 - Improving some of the existing scripts as bugfix.

The additional queries use existing shell commands that are already manually used by the OVS community for trouble-shooting,


David Patrik Pinter (4):
  ovs-bugtool: Bugfix for bugtool plugin queries.
  ovs-bugtool: Refactorize bugtool plugin xml files.
  ovs-bugtool: Enhancement of bugtool plugins.
  ovs-bugtool: Extend bugtool with query repeat feature.

 utilities/bugtool/automake.mk                      | 21 +++++-------------
 utilities/bugtool/ovs-bugtool-ovs-ofctl-dump-flows | 24 ---------------
 .../ovs-bugtool-ovs-ofctl-loop-over-bridges        | 34 ++++++++++++++++++++++
 utilities/bugtool/ovs-bugtool-ovs-ofctl-show       | 24 ---------------
 utilities/bugtool/ovs-bugtool-bfd-show               | 19 -------------------
 utilities/bugtool/ovs-bugtool-bond-show              | 19 -------------------
 utilities/bugtool/ovs-bugtool-cfm-show               | 19 -------------------
 utilities/bugtool/ovs-bugtool-conntrack-dump         | 19 -------------------
 utilities/bugtool/ovs-bugtool-coverage-show          | 19 -------------------
 utilities/bugtool/ovs-bugtool-lacp-show              | 19 -------------------
 utilities/bugtool/ovs-bugtool-list-dbs               | 19 -------------------
 utilities/bugtool/ovs-bugtool-memory-show            | 19 -------------------
 utilities/bugtool/ovs-bugtool-ovsdb-dump             | 19 -------------------
 utilities/bugtool/ovs-bugtool-vsctl-show             | 19 -------------------
 utilities/bugtool/ovs-bugtool-get-dpdk-nic-numa    | 25 ++++++++++++++
 .../bugtool/ovs-bugtool-ovs-bridge-datapath-type   | 22 +++++++++++++
 .../ovs-bugtool-ovs-vswitchd-threads-affinity      | 25 ++++++++++++++
 utilities/bugtool/ovs-bugtool-qos-configs          | 29 +++++++++++++++++
 .../bugtool/plugins/network-status/openvswitch.xml | 74 ++++++++++++++++++++++++++-----------------------
 .../bugtool/plugins/kernel-info/openvswitch.xml    | 6 ++--
 .../plugins/system-configuration/openvswitch.xml   | 25 ++++++++++++++
 .../bugtool/plugins/system-logs/openvswitch.xml    | 21 ++++++++++--
 utilities/bugtool/ovs-bugtool.in                   | 72 ++++++++++++++++++++++++++++++++++----------
 28 files changed, 285 insertions(+), 307 deletions(-)  delete mode 100755 utilities/bugtool/ovs-bugtool-ovs-ofctl-dump-flows
 delete mode 100755 utilities/bugtool/ovs-bugtool-ovs-ofctl-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-bfd-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-bond-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-cfm-show
 delete mode 100644 utilities/bugtool/ovs-bugtool-conntrack-dump
 delete mode 100755 utilities/bugtool/ovs-bugtool-coverage-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-lacp-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-list-dbs
 delete mode 100755 utilities/bugtool/ovs-bugtool-memory-show
 delete mode 100755 utilities/bugtool/ovs-bugtool-ovsdb-dump
 delete mode 100755 utilities/bugtool/ovs-bugtool-vsctl-show
 create mode 100755 utilities/bugtool/ovs-bugtool-ovs-ofctl-loop-over-bridges
 create mode 100755 utilities/bugtool/ovs-bugtool-get-dpdk-nic-numa
 create mode 100755 utilities/bugtool/ovs-bugtool-ovs-bridge-datapath-type
 create mode 100755 utilities/bugtool/ovs-bugtool-ovs-vswitchd-threads-affinity
 create mode 100755 utilities/bugtool/ovs-bugtool-qos-configs

--
2.7.4


More information about the dev mailing list