[ovs-dev] [PATCH v6 1/2] dpif-netdev: Refactor PMD performance into dpif-netdev-perf

Jan Scheurich jan.scheurich at ericsson.com
Wed Jan 10 22:46:38 UTC 2018


> > >
> > > -    unixctl_command_register("dpif-netdev/pmd-stats-show", "[dp]",
> > > -                             0, 1, dpif_netdev_pmd_info,
> > > +    unixctl_command_register("dpif-netdev/pmd-stats-show", "[-pmd core | dp]",
> >
> > It should be "[-pmd core] [dp]".
> > Current version means "optionally, only one of arguments".
> > Same in all other cases below.
> 
> The code actually either accepts "-pmd core" or "dp" but not both. That is logical because the specification of "-p pmd" implies the
> datapath. I have never understood why there is a need for "dp" after all as there is only a single netdev userspace datapath (netdev at ovs-
> netdev or so). But it is still required if there is a kernel datapath configured.

Sorry, checked the code again during rework. You are right. It should be "[-pmd core] [dp]".

Jan


More information about the dev mailing list