[ovs-dev] [PATCH v8 1/3] nsh: add new flow key 'ttl'

Ben Pfaff blp at ovn.org
Wed Jan 10 22:53:49 UTC 2018


On Wed, Jan 10, 2018 at 02:50:35PM -0800, Ben Pfaff wrote:
> On Tue, Jan 09, 2018 at 09:56:16PM +0800, Yi Yang wrote:
> > IETF NSH draft added a new filed ttl in NSH header, this patch
> > is to add new nsh key 'ttl' for it.
> > 
> > Signed-off-by: Yi Yang <yi.y.yang at intel.com>
> 
> Thanks for the revision!
> 
> This breaks a test:
> 
> 939: ofproto - table features (OpenFlow 1.3)         FAILED (ofproto.at:2607)
> 
> This change is user-visible so it should have a NEWS item.
> 
> I'm appending some suggested minor improvements.
> 
> Thanks again,
> 
> Ben.

Oh, and it still doesn't add good documentation to ovs-fields(7) that is
comparable to the detail for the other protocols there.  Please add some
background, description, and references.

Thanks,

Ben.


More information about the dev mailing list