[ovs-dev] [PATCH v7] ofproto-dpif-ipfix: add interface Information Elements to flow key

Ben Pfaff blp at ovn.org
Wed Jan 10 23:13:35 UTC 2018


On Wed, Jan 10, 2018 at 01:06:03PM +0000, Michal Weglicki wrote:
> Extend flow key part of data record to include following Information Elements:
> - ingressInterface
> - ingressInterfaceType
> - egressInterface
> - egressInterfaceType
> - interfaceName
> - interfaceDescription
> 
> In case of input sampling we don't have information about egress port.
> Define templates depending not only on protocol types, but also on flow
> direction. Only egress flow will include egress information elements.
> 
> With this change, dpif_ipfix_exporter stores every port in hmap rather
> than only tunnel ports. It allows to easily retrieve required
> information about interfaces during sampling upcalls.
> 
> v1->v2
> * Add interfaceType and interfaceDescription
> * Rework ipfix_get_iface_data_record function
> v2->v3: Code rebase.
> v3->v4: Minor comments applied.
> v4->v5: Clang complation problem fix.
> v6->v7: Code rebase.
> 
> Co-authored-by: Michal Weglicki <michalx.weglicki at intel.com>
> Signed-off-by: Michal Weglicki <michalx.weglicki at intel.com>
> Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik at intel.com>

Thanks for the revision (and for your patience)!  I applied this to
master.

Probably we should have a NEWS item but I didn't know how to properly
summarize this.  Please consider sending a patch that just adds a NEWS
item.

Thanks,

Ben.


More information about the dev mailing list