[ovs-dev] [PATCH 1/1] odp-util: Fix Sparse warning.

Ben Pfaff blp at ovn.org
Thu Jan 11 18:27:32 UTC 2018


On Thu, Jan 11, 2018 at 05:58:58PM +0000, Ian Stokes wrote:
> Sparse complains with warning: incorrect type in argument 1 (different
> base types) in function parse_odp_userspace_action due to a call to
> htonll(rule_cookie). Rule_cookie variable is already ovs_be64 so fix
> this by removing the call to htonll as there is no need to convert for
> use with put_32aligned_be64().
> 
> CC: Justin Pettit <jpettit at ovn.org>
> Fixes: d39ec23de384 ("ofproto-dpif: Don't slow-path controller actions.")
> Signed-off-by: Ian Stokes <ian.stokes at intel.com>

Thanks for the fix.

I noticed that one of the tests broke when I applied this, so I found
the problem and sent v2:
        https://patchwork.ozlabs.org/patch/859232/

Justin?


More information about the dev mailing list