[ovs-dev] [PATCH 05/15] ovsdb: Drop distinction between monitors and replicas.

Ben Pfaff blp at ovn.org
Mon Jan 22 19:21:04 UTC 2018


On Fri, Jan 12, 2018 at 06:24:28PM -0800, Justin Pettit wrote:
> 
> 
> > On Dec 31, 2017, at 9:16 PM, Ben Pfaff <blp at ovn.org> wrote:
> > 
> > diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c
> > index b2ecd109ed60..3e58c3fbd274 100644
> > --- a/ovsdb/monitor.c
> > +++ b/ovsdb/monitor.c
> > 
> > +void
> > +ovsdb_monitors_remove(struct ovsdb *db)
> > +{
> > +    struct ovsdb_monitor *m, *next_m;
> > +
> > +    LIST_FOR_EACH_SAFE (m, next_m, list_node, &db->monitors) {
> > +        struct jsonrpc_monitor_node *jm, *next_jm;
> > +
> > +        /* Delete all front end monitors. Removing the last front
> > +         * end monitor will also destroy the corresponding 'ovsdb_monitor'.
> > +         * ovsdb monitor will also be destroied.  */
> 
> I found the last sentence confusing based on the previous sentence.  Also, "destroyed" is misspelled.

Thanks, I fixed the comment.

> Acked-by: Justin Pettit <jpettit at ovn.org>

Thanks!


More information about the dev mailing list