[ovs-dev] [PATCH 2/2] datapath: add ct_clear action

[Ben Pfaff]

On Mon, Jan 22, 2018 at 02:34:53PM -0800, Pravin Shelar wrote:
> On Mon, Jan 22, 2018 at 11:10 AM, Eric Garver <e at erig.me> wrote:
> > Upstream commit:
> >     commit b8226962b1c49c784aeddb9d2fafbf53dfdc2190
> >     Author: Eric Garver <e at erig.me>
> >     Date:   Tue Oct 10 16:54:44 2017 -0400
> >
> >     openvswitch: add ct_clear action
> >
> >     This adds a ct_clear action for clearing conntrack state. ct_clear is
> >     currently implemented in OVS userspace, but is not backed by an action
> >     in the kernel datapath. This is useful for flows that may modify a
> >     packet tuple after a ct lookup has already occurred.
> >
> >     Signed-off-by: Eric Garver <e at erig.me>
> >     Acked-by: Pravin B Shelar <pshelar at ovn.org>
> >     Signed-off-by: David S. Miller <davem at davemloft.net>
> >
> > Notes:
> >    - hunk from include/uapi/linux/openvswitch.h is missing because it
> >      was added with userspace support in 1fe178d251c8 ("dpif: Add support
> >      for OVS_ACTION_ATTR_CT_CLEAR")
> >    - if IP_CT_UNTRACKED is not available use 0 as other nf_ct_set()
> >      calls do. Since we're setting ct to NULL this is okay.
> >
> > Signed-off-by: Eric Garver <e at erig.me>
> 
> LGTM.
> 
> Acked-by: Pravin B Shelar <pshelar at ovn.org>

Thanks for reviewing this patch series.  Do you intend to apply it
directly to the OVS repo, or would you prefer for someone else to do it?

Thanks,

Ben.