[ovs-dev] [PATCH V2] compat:inet_frag.h: Check for frag_percpu_counter_batch

Gregory Rose gvrose8192 at gmail.com
Tue Jan 23 20:01:59 UTC 2018


On 1/23/2018 12:00 PM, Justin Pettit wrote:
>
>> On Jan 5, 2018, at 11:30 AM, Greg Rose <gvrose8192 at gmail.com> wrote:
>>
>> +#ifdef frag_percpu_counter_batch
>> ...
>> +#else /* frag_percpu_counter_batch */
> This is kind of a nit, but I would have thought this "#else" comment would be "!frag_percpu_counter_batch", since that's the case when it's not defined.  However, I'm not sure how it's handled usually in the kernel.  Looking through our compat code, I see examples of it being done both ways, though.  Thoughts?
>
> --Justin
>
>
It's a valid nit.

I can send V2 or you can fix it on push.  Which do you prefer?

Thanks,

- Greg


More information about the dev mailing list