[ovs-dev] [PATCH] ovn.at: Fix IPv6 periodic RA test on Windows

aserdean at ovn.org aserdean at ovn.org
Tue Jan 23 21:02:13 UTC 2018


Thanks for the review!

I have a "\n" which isn't OK. Also, even with that changed I get the
following:
+++ /c/_2018/january/23/ovs/tests/testsuite.dir/at-groups/2378/stdout
2018-01-23 22:58:49 +0200
@@ -1 +1 @@
-ff4000000000000000000000010100000000000105010000000005dc03044080fffffffffff
fffff00000000aef0000000000000000000000000000003043080ffffffffffffffff0000000
0fd0f0000000000000000000000000000
+ff8000000000000000000000010100000000000105010000000005dc03044080fffffffffff
fffff00000000aef0000000000000000000000000000003043080ffffffffffffffff0000000
0fd0f0000000000000000000000000000
I will look into it and send another revision!

Thanks,
Alin.

> -----Original Message-----
> From: Ben Pfaff [mailto:blp at ovn.org]
> Sent: Tuesday, January 23, 2018 2:20 AM
> To: Alin Gabriel Serdean <aserdean at ovn.org>
> Cc: dev at openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] ovn.at: Fix IPv6 periodic RA test on
Windows
> 
> On Sun, Jan 14, 2018 at 07:05:16PM +0200, Alin Gabriel Serdean wrote:
> > One issue with this test is that MSYS mangles the shorter form of the
IPv6
> address.
> > To solve this, we switch to the longer notation of it.
> >
> > Another issue is that `printf` command does not add the leading `0` to
the
> packet.
> > We switch to a more platform independent `awk` substitution.
> >
> > Co-authored-by: Mark Michelson <mmichels at redhat.com>
> > Signed-off-by: Mark Michelson <mmichels at redhat.com>
> > Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> 
> Acked-by: Ben Pfaff <blp at ovn.org>



More information about the dev mailing list