[ovs-dev] [PATCH v2 3/5] Remove last mentions of 'facet' from comments.

Ben Pfaff blp at ovn.org
Wed Jan 24 19:40:18 UTC 2018


How did these survive so long?!  OVS hasn't had facets since 2013.

Signed-off-by: Ben Pfaff <blp at ovn.org>
---
 lib/odp-util.h                |  2 +-
 ofproto/ofproto-dpif-mirror.c | 11 +++++------
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/lib/odp-util.h b/lib/odp-util.h
index 55c922c9fdd1..0fcc593d2ace 100644
--- a/lib/odp-util.h
+++ b/lib/odp-util.h
@@ -54,7 +54,7 @@ enum {
 #undef SPR
 };
 
-/* Reasons why a subfacet might not be fast-pathable.
+/* Reasons why a flow might not be fast-pathable.
  *
  * Each reason is a separate bit to allow reasons to be combined. */
 enum slow_path_reason {
diff --git a/ofproto/ofproto-dpif-mirror.c b/ofproto/ofproto-dpif-mirror.c
index 4659a7d93a5b..343b75f0ed01 100644
--- a/ofproto/ofproto-dpif-mirror.c
+++ b/ofproto/ofproto-dpif-mirror.c
@@ -387,12 +387,11 @@ mirror_update_stats(struct mbridge *mbridge, mirror_mask_t mirrors,
         m = mbridge->mirrors[raw_ctz(mirrors)];
 
         if (!m) {
-            /* In normal circumstances 'm' will not be NULL.  However,
-             * if mirrors are reconfigured, we can temporarily get out
-             * of sync in facet_revalidate().  We could "correct" the
-             * mirror list before reaching here, but doing that would
-             * not properly account the traffic stats we've currently
-             * accumulated for previous mirror configuration. */
+            /* In normal circumstances 'm' will not be NULL.  However, if
+             * mirrors are reconfigured, we can temporarily get out of sync.
+             * We could "correct" the mirror list before reaching here, but
+             * doing that would not properly account the traffic stats we've
+             * currently accumulated for previous mirror configuration. */
             continue;
         }
 
-- 
2.10.2



More information about the dev mailing list