[ovs-dev] [PATCH] rhel: Change depmod configuration

Gregory Rose gvrose8192 at gmail.com
Thu Jan 25 21:05:04 UTC 2018


On 1/25/2018 12:58 PM, Aaron Conole wrote:
> Hi Greg,
>
> Greg Rose <gvrose8192 at gmail.com> writes:
>
>> A previous patch added post install and post uninstall scripts which
>> use the weak-modules utility to make sure that openvswitch kernel
>> modules are copied to the correct kernel directory.  While this
>> patch did fix some issues there are two remaining issues we have
>> found.
>>
>> 1) In the case where the OS is running kernel X and the openvswitch
>>     kernel modules have been previously installed correctly and are
>>     working without a problem and then updating to Kernel X.1 we find
>>     that the correct openvswitch kernel module no longer loads.
>> 2) In the case where a kernel module rpm has been built against an
>>     older kernel but installed on a newer kernel then the correct
>>     openvswitch kernel module will not load.
>>
>> This patch changes the weak-modules parameter to --add-kernel instead
>> of --add-modules. This fixes the problem in case 1.  In addition
>> we modify the openvswitch depmod configuration file installed to the
>> /etc/depmod.d directory and prepend a "01" to the name of the file.
>> We then insert the first line of the file with a search path that
>> will find weak-updates first. This change along with the change
>> to the weak-modules utility parameters fixes the problem in case 2.
>>
>> I also modified the kernel module configuration file for both the
>> rhel6 and rhel7/fedora specs to use a common "01openvswitch.conf"
>> file name format.
>>
>> Cc: Flavio Leitner <fbl at sysclose.org>
>> Co-authored-by: Gurucharan Shetty <guru at ovn.org>
>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>> ---
> Nit: The co-authored-by requires a signoff (according to the
> contributing guide) from the author.

Oops.  I'll send  V2 with that fixed after more review time.  I'm hoping 
Flavio can review it
since he reviewed the initial patches.

Thanks,

- Greg

>
> I didn't look at the contents of the patch since I'm not as familiar
> with weak-updates as I probably should be (more of a dkms fan, myself).
>
> -Aaron



More information about the dev mailing list