[ovs-dev] [PATCH 3/4] flow: Add some L7 payload data to most L4 protocols that accept it.

Ben Pfaff blp at ovn.org
Fri Jan 26 23:04:41 UTC 2018


On Fri, Jan 26, 2018 at 01:52:09PM -0800, Yifeng Sun wrote:
> Hi Ben,
> 
> I found an issue in the lines below. It looks like that the 'else if' part
> is redundant.
> 
> +        if (dp_packet_size(packet) < packet_size) {
> +            packet_expand(packet, &flow, packet_size);
> +        } else if (dp_packet_size(packet) < packet_size){
> +            dp_packet_delete(packet);
> +            packet = NULL;
> +        }

Oops.  In the second "if", "<" should be ">".

> And do you know which commit this patch is based on? I am having problem
> to apply this patch and test it out.

I guess master changed.  I rebased, applied patches 1 and 2, and
re-posted the remaining patches as v2:
        https://patchwork.ozlabs.org/project/openvswitch/list/?series=25681


More information about the dev mailing list