[ovs-dev] [ovs-dev, 01 of 23] db-ctl-base: Don't die in parse_column_names() on error.

Jakub Sitnicki jkbs at redhat.com
Mon Jul 2 11:02:34 UTC 2018


On Mon,  2 Jul 2018 06:55:57 -0400
0-day Robot <robot at bytheb.org> wrote:

> Bleep bloop.  Greetings Jakub Sitnicki, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> checkpatch:
> WARNING: Line is 80 characters long (recommended limit is 79)
> #62 FILE: lib/db-ctl-base.c:988:
>     die_if_error(parse_column_names(column_names, table, &columns, &n_columns));
> 
> WARNING: Line is 80 characters long (recommended limit is 79)
> #71 FILE: lib/db-ctl-base.c:1077:
>     die_if_error(parse_column_names(column_names, table, &columns, &n_columns));
> 
> WARNING: Line is 80 characters long (recommended limit is 79)
> #80 FILE: lib/db-ctl-base.c:1150:
>     die_if_error(parse_column_names(column_names, table, &columns, &n_columns));
> 
> Lines checked: 87, Warnings: 3, Errors: 0

Thanks, robot! Patch 15/23 removes the offending lines. Hopefully the
warnings can be ignored.

BTW. To anyone reading the series - cover letter for this series is
coming. It got detained and needs to be approved by the moderator for
some reason.

-Jakub


More information about the dev mailing list