[ovs-dev] [PATCH v1 02/14] dp-packet: Init specific mbuf fields.

Eelco Chaudron echaudro at redhat.com
Tue Jul 3 09:43:39 UTC 2018



On 28 Jun 2018, at 17:41, Tiago Lam wrote:

> From: Mark Kavanagh <mark.b.kavanagh at intel.com>
>
> dp_packets are created using xmalloc(); in the case of OvS-DPDK, it's
> possible the the resultant mbuf portion of the dp_packet contains
> random data. For some mbuf fields, specifically those related to
> multi-segment mbufs and/or offload features, random values may cause
> unexpected behaviour, should the dp_packet's contents be later copied
> to a DPDK mbuf. It is critical therefore, that these fields should be
> initialized to 0.
>
> This patch ensures that the following mbuf fields are initialized to
> appropriate values on creation of a new dp_packet:
>    - ol_flags=0
>    - nb_segs=1
>    - tx_offload=0
>    - packet_type=0
>    - next=NULL
>
> Adapted from an idea by Michael Qiu <qiudayu at chinac.com>:
> https://patchwork.ozlabs.org/patch/777570/
>
> Co-authored-by: Tiago Lam <tiago.lam at intel.com>
>
> Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
> Signed-off-by: Tiago Lam <tiago.lam at intel.com>

LGTM,

Acked-by: Eelco Chaudron <echaudro at redhat.com>

<SNIP>


More information about the dev mailing list