[ovs-dev] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo
0-day Robot
robot at bytheb.org
Thu Jul 5 23:26:57 UTC 2018
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: No signatures found.
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#357 FILE: tests/oss-fuzz/flow_extract_target.c:4:
int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#388 FILE: tests/oss-fuzz/json_parser_target.c:17:
int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
ERROR: Inappropriate bracing around statement
#390 FILE: tests/oss-fuzz/json_parser_target.c:19:
if ((size == 0) || (data[size-1] != '\0')) return 0;
WARNING: Line lacks whitespace around operator
#392 FILE: tests/oss-fuzz/json_parser_target.c:21:
struct json *j1,*j2;
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#402 FILE: tests/oss-fuzz/json_parser_target.c:31:
WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#414 FILE: tests/oss-fuzz/json_parser_target.c:43:
ERROR: Inappropriate spacing in pointer declaration
WARNING: Line lacks whitespace around operator
#446 FILE: tests/oss-fuzz/ofp_print_target.c:6:
int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size)
ERROR: Inappropriate bracing around statement
#450 FILE: tests/oss-fuzz/ofp_print_target.c:10:
if (size < sizeof(struct ofp_header)) return 0;
WARNING: Line has non-spaces leading whitespace
#453 FILE: tests/oss-fuzz/ofp_print_target.c:13:
vlog_set_verbosity("off");
WARNING: Line has non-spaces leading whitespace
#454 FILE: tests/oss-fuzz/ofp_print_target.c:14:
isInit = true;
WARNING: Line has non-spaces leading whitespace
#459 FILE: tests/oss-fuzz/ofp_print_target.c:19:
struct ofp_header *oh;
WARNING: Line has non-spaces leading whitespace
#460 FILE: tests/oss-fuzz/ofp_print_target.c:20:
size_t length, tail_len;
WARNING: Line has non-spaces leading whitespace
#461 FILE: tests/oss-fuzz/ofp_print_target.c:21:
void *tail;
WARNING: Line has non-spaces leading whitespace
#463 FILE: tests/oss-fuzz/ofp_print_target.c:23:
// Check if ofpbuf contains ofp header
WARNING: Line has non-spaces leading whitespace
#464 FILE: tests/oss-fuzz/ofp_print_target.c:24:
oh = (struct ofp_header *)ofpbuf_at(&b, 0, sizeof *oh);
WARNING: Line has non-spaces leading whitespace
#465 FILE: tests/oss-fuzz/ofp_print_target.c:25:
if (!oh) break;
WARNING: Line has non-spaces leading whitespace
#467 FILE: tests/oss-fuzz/ofp_print_target.c:27:
// Check if length is geq than lower bound
WARNING: Line has non-spaces leading whitespace
#468 FILE: tests/oss-fuzz/ofp_print_target.c:28:
length = ntohs(oh->length);
WARNING: Line has non-spaces leading whitespace
#469 FILE: tests/oss-fuzz/ofp_print_target.c:29:
if (length < sizeof *oh) break;
WARNING: Line has non-spaces leading whitespace
#471 FILE: tests/oss-fuzz/ofp_print_target.c:31:
// Check if ofpbuf contains payload
WARNING: Line has non-spaces leading whitespace
#472 FILE: tests/oss-fuzz/ofp_print_target.c:32:
tail_len = length - sizeof *oh;
WARNING: Line has non-spaces leading whitespace
#473 FILE: tests/oss-fuzz/ofp_print_target.c:33:
tail = ofpbuf_at(&b, sizeof *oh, tail_len);
WARNING: Line has non-spaces leading whitespace
#474 FILE: tests/oss-fuzz/ofp_print_target.c:34:
if (!tail) break;
WARNING: Line has non-spaces leading whitespace
#476 FILE: tests/oss-fuzz/ofp_print_target.c:36:
ofp_print(stdout, ofpbuf_pull(&b, length), length, NULL, NULL, 2);
Lines checked: 484, Warnings: 24, Errors: 6
build:
sed -e '34,/%AUTHORS%/d' ./debian/copyright.in; \
} > debian/copyright
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') < ./rhel/openvswitch-dkms.spec.in > openvswitch-dkms.spec.tmp || exit 1; if cmp -s openvswitch-dkms.spec.tmp rhel/openvswitch-dkms.spec; then touch rhel/openvswitch-dkms.spec; rm openvswitch-dkms.spec.tmp; else mv openvswitch-dkms.spec.tmp rhel/openvswitch-dkms.spec; fi
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') < ./rhel/openvswitch-kmod-rhel6.spec.in > openvswitch-kmod-rhel6.spec.tmp || exit 1; if cmp -s openvswitch-kmod-rhel6.spec.tmp rhel/openvswitch-kmod-rhel6.spec; then touch rhel/openvswitch-kmod-rhel6.spec; rm openvswitch-kmod-rhel6.spec.tmp; else mv openvswitch-kmod-rhel6.spec.tmp rhel/openvswitch-kmod-rhel6.spec; fi
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') < ./rhel/openvswitch-kmod-fedora.spec.in > openvswitch-kmod-fedora.spec.tmp || exit 1; if cmp -s openvswitch-kmod-fedora.spec.tmp rhel/openvswitch-kmod-fedora.spec; then touch rhel/openvswitch-kmod-fedora.spec; rm openvswitch-kmod-fedora.spec.tmp; else mv openvswitch-kmod-fedora.spec.tmp rhel/openvswitch-kmod-fedora.spec; fi
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') < ./rhel/openvswitch.spec.in > openvswitch.spec.tmp || exit 1; if cmp -s openvswitch.spec.tmp rhel/openvswitch.spec; then touch rhel/openvswitch.spec; rm openvswitch.spec.tmp; else mv openvswitch.spec.tmp rhel/openvswitch.spec; fi
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') < ./rhel/openvswitch-fedora.spec.in > openvswitch-fedora.spec.tmp || exit 1; if cmp -s openvswitch-fedora.spec.tmp rhel/openvswitch-fedora.spec; then touch rhel/openvswitch-fedora.spec; rm openvswitch-fedora.spec.tmp; else mv openvswitch-fedora.spec.tmp rhel/openvswitch-fedora.spec; fi
(printf '\043 Generated automatically -- do not modify! -*- buffer-read-only: t -*-\n' && sed -e 's,[@]VERSION[@],2.9.90,g') \
< ./xenserver/openvswitch-xen.spec.in > openvswitch-xen.spec.tmp || exit 1; \
if cmp -s openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; then touch xenserver/openvswitch-xen.spec; rm openvswitch-xen.spec.tmp; else mv openvswitch-xen.spec.tmp xenserver/openvswitch-xen.spec; fi
make[3]: Entering directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/datapath'
The following files are in git but not the distribution:
tests/oss-fuzz/config/flow_extract_fuzzer.options
tests/oss-fuzz/config/json_parser_fuzzer.options
tests/oss-fuzz/config/ofp_print_fuzzer.options
tests/oss-fuzz/config/ovs.dict
tests/oss-fuzz/flow_extract_target.c
tests/oss-fuzz/json_parser_target.c
tests/oss-fuzz/ofp_print_target.c
make[2]: *** [dist-hook-git] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2
Please check this out. If you feel there has been an error, please email aconole at bytheb.org
Thanks,
0-day Robot
More information about the dev
mailing list