[ovs-dev] [PATCH] oss-fuzz: Move oss-fuzz test harnesses and fuzzer configs to ovs source repo

[Bhargava Shastry]

> Is that the preferred way to do it?  It seems a little ad hoc.  Another
> way would be to add a target to the OVS build tree, so that the script
> could just become something like
> 
>         ./boot.sh && ./configure && make -j$(nproc) tests/oss-fuzz/fuzzer
> 
> or whatever.

This is cleaner and my preference as well. How do I go about doing this?

> 
> But, maybe this ad hoc build method is conventional for oss-fuzz?  I'm
> not familiar with their usual processes.

I don't think Google cares how targets are built although a lot of
targets are currently built in an ad-hoc way.

> Well, either they have to have #include <config.h> or we need to
> blacklist these files, one or the other.  The former is probably
> harmless and possibly helpful.

Let's add a make target for oss-fuzz and and everything that is needed
to get that done. I suppose this means I add a #include <config.h> as
the first line of each of the fuzz test harnesses?

>>> The new files need to get mentioned in an automake.mk, at least in
>>> EXTRA_DIST, to ensure that "make dist" will put them into the tarball:
>>>
>>>     The following files are in git but not the distribution:
>>>     tests/oss-fuzz/config/flow_extract_fuzzer.options
>>>     tests/oss-fuzz/config/json_parser_fuzzer.options
>>>     tests/oss-fuzz/config/ofp_print_fuzzer.options
>>>     tests/oss-fuzz/config/ovs.dict
>>>     tests/oss-fuzz/flow_extract_target.c
>>>     tests/oss-fuzz/json_parser_target.c
>>>     tests/oss-fuzz/ofp_print_target.c
>>
>> There are several automake files to choose from. How do I do this?
> 
> I'd add a new tests/oss-fuzz/automake.mk and then include that in
> tests/automake.mk.

I am not sure about this step. I will get back to you once we have a
make target ready.

Thanks.
Bhargava