[ovs-dev] [PATCH 02/30] ovn-nbctl: Report the actual error from the command handler.

Jakub Sitnicki jkbs at redhat.com
Sat Jul 7 11:09:36 UTC 2018


Fix a typo that went undetected by tests because we don't have any test
cases for error paths when using database commands with ovn-nbctl.

Fixes: 675b152e999f ("db-ctl-base: Extend ctl_context with an error message.")
Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
---
 ovn/utilities/ovn-nbctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ovn/utilities/ovn-nbctl.c b/ovn/utilities/ovn-nbctl.c
index fbdb5a4d9..762348ccb 100644
--- a/ovn/utilities/ovn-nbctl.c
+++ b/ovn/utilities/ovn-nbctl.c
@@ -3843,7 +3843,7 @@ do_nbctl(const char *args, struct ctl_command *commands, size_t n_commands,
             (c->syntax->run)(&ctx);
         }
         if (ctx.error) {
-            ctl_fatal("%s", error);
+            ctl_fatal("%s", ctx.error);
         }
         ctl_context_done_command(&ctx, c);
 
-- 
2.14.4



More information about the dev mailing list