[ovs-dev] [PATCH] ofproto: Return error codes for Rule insertions

Aravind Prasad raja.avi at gmail.com
Mon Jul 9 05:57:06 UTC 2018


Hi Aaron,
> Currently, rule_insert() API doesnot have return value. There are some
> possible
> scenarios where rule insertions can fail at run-time even though the
static
> checks during rule_construct() had passed previously.
>
> Some possible scenarios for failure of rule insertions:
> **) Rule insertions can fail dynamically in Hybrid mode (both Openflow and
> Normal switch functioning coexist) where the CAM space could get suddenly
> filled up by Normal switch functioning and Openflow gets devoid of
> available space.
> **) Some deployments could have separate independent layers for HW rule
> insertions and application layer to interact with OVS. HW layer
> could face any dynamic issue during rule handling which application could
> not have predicted/captured in rule-construction phase.
>
> Rule-insert errors for bundles are not handled in this pull-request.
> Will be handled in upcoming pull request.
>
> Signed-off-by: Aravind Prasad S <raja.avi at gmail.com>
> ---

>> Thanks for working on OVS.

>> As noted, the patch has some submission errors.  Please try submitting
>> again with 'git send-email' to eliminate any potential mail client
>> munging.

Thanks a lot for the info and support. Submitted the patch with git -email.
OVS group rocks :-). Very active in assistance and support too.

Thanks,
S. Aravind Prasad

On Mon, Jul 9, 2018 at 5:09 AM Aaron Conole <aconole at redhat.com> wrote:

> Hi Arvind,
>
> Aravind Prasad <raja.avi at gmail.com> writes:
>
> > Currently, rule_insert() API doesnot have return value. There are some
> > possible
> > scenarios where rule insertions can fail at run-time even though the
> static
> > checks during rule_construct() had passed previously.
> >
> > Some possible scenarios for failure of rule insertions:
> > **) Rule insertions can fail dynamically in Hybrid mode (both Openflow
> and
> > Normal switch functioning coexist) where the CAM space could get suddenly
> > filled up by Normal switch functioning and Openflow gets devoid of
> > available space.
> > **) Some deployments could have separate independent layers for HW rule
> > insertions and application layer to interact with OVS. HW layer
> > could face any dynamic issue during rule handling which application could
> > not have predicted/captured in rule-construction phase.
> >
> > Rule-insert errors for bundles are not handled in this pull-request.
> > Will be handled in upcoming pull request.
> >
> > Signed-off-by: Aravind Prasad S <raja.avi at gmail.com>
> > ---
>
> Thanks for working on OVS.
>
> As noted, the patch has some submission errors.  Please try submitting
> again with 'git send-email' to eliminate any potential mail client
> munging.
>
> -Aaron
>


More information about the dev mailing list