[ovs-dev] [PATCH 04/14] datapath-windows: Cleanup Datapath.c

Alin Gabriel Serdean aserdean at ovn.org
Mon Jul 9 13:40:46 UTC 2018


Assign variable directly instead of reassigning it after.

Do not assign an initial value to `inputBuffer`, it will be assigned later
on.

Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
---
 datapath-windows/ovsext/Datapath.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/datapath-windows/ovsext/Datapath.c b/datapath-windows/ovsext/Datapath.c
index 34ef2b40a..448558701 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b/datapath-windows/ovsext/Datapath.c
@@ -407,7 +407,7 @@ FreeUserDumpState(POVS_OPEN_INSTANCE instance)
 NDIS_STATUS
 OvsInit()
 {
-    NDIS_STATUS status = NDIS_STATUS_SUCCESS;
+    NDIS_STATUS status;
 
     gOvsCtrlLock = &ovsCtrlLockObj;
     NdisAllocateSpinLock(gOvsCtrlLock);
@@ -720,7 +720,7 @@ OvsDeviceControl(PDEVICE_OBJECT deviceObject,
     PIO_STACK_LOCATION irpSp;
     NTSTATUS status = STATUS_SUCCESS;
     PFILE_OBJECT fileObject;
-    PVOID inputBuffer = NULL;
+    PVOID inputBuffer;
     PVOID outputBuffer = NULL;
     UINT32 inputBufferLen, outputBufferLen;
     UINT32 code, replyLen = 0;
-- 
2.16.1.windows.1



More information about the dev mailing list