[ovs-dev] [PATCH v2 2/2] python jsonrpc: Allow jsonrpc_session to have more than one remote.

Ben Pfaff blp at ovn.org
Mon Jul 9 18:17:50 UTC 2018


On Sun, Jul 08, 2018 at 10:05:57PM +0530, nusiddiq at redhat.com wrote:
> From: Numan Siddique <nusiddiq at redhat.com>
> 
> Python IDL implementation doesn't have the support to connect to the
> cluster dbs. This patch adds this support. We are still missing the
> support in python idl class to connect to the cluster master. That
> support will be added in an upcoming patch.
> 
> This patch is similar to the commit 8cf6bbb184 which added multiple remote
> support in the C jsonrpc implementation.
> 
> Signed-off-by: Numan Siddique <nusiddiq at redhat.com>

Thanks for working on bringing the Python code up to speed with the C
code.

The one possibly important difference between this and the C code in
commit 8cf6bbb184 is that the C code for jsonrpc_session_open() doesn't
break the string into multiple ones at commas, whereas the Python code
does.  I thought about that for a while when I wrote the C version, and
I decided to only split the string inside the IDL because that's the
only user that understands multiple remotes and because I was concerned
that people might have file names that contain commas (in unix:)
remotes.  Would you mind making the Python version resemble the C
version in this respect?

Thanks,

Ben.


More information about the dev mailing list