[ovs-dev] [patch v7 0/9] Userspace datapath: Add fragmentation support.

Darrell Ball dlu998 at gmail.com
Mon Jul 9 23:48:06 UTC 2018


Fragmentation support for userspace datapath conntrack is added; both
v4 and v6 are supported. See the patches for additional details.

Fragmentation tests for the userspace datapath are enabled
by the patches and other test enhancements are added.

v6->v7: Address review comments (Thanks Justin).
        Rebase.
        Fix a couple bugs.
        Some enhancements.

v5->v6: Rebase
        Folded patch 4 and some test enablement into patch 3 and brought
            an earlier patch forward in sequence
        Enable fragmentation by default
        Cleaup

v4->v5: Added a sub-feature to optionally dump fragmentation lists.
        This is useful for DOS forensics and debugging.

        The testing coverage was also extended including checking
        more counters and frag list occupancies.

        Fixed a few bugs:
        1/ Handle dpdk mempool source restrictions for a batch of
           packets from multiple sources; this also brings in a purge
           frag list function to handle pathological cases of stuck frags.
        2/ ipf_destroy was missing packet frees for frag lists.
        3/ A setting of CS_INVALID was missing for expired packets -
           I mentioned this earlier for version 4.

        Some enhancements and coding standards changes for Patch 3.

v3->v4: Add V6 support to the patches.
        Fix possible race cleanup bug when the user disables
           fragmentation and there are list occupancies, not cleaned up
           yet.
        Add missed orig tuple fields for copy from reassembled packet
            to fragments.
        Fix an fragment list increment check - shoiuld have been "> 0"
            rather then "!= 0".
        Fix max frags calculation in case of theoretical corner case.
        Add proper lock annotations.
        Made some other improvements while adding V6 support.

v2->v3: Patch 2 was updated:
        Remove "XXX" todo items by implementing the ones needed,
        including realloc frag_list contexts to save memory.
        Fix related bug with max_frag_list_size when min_frag_size is
        reconfigured.

        Tighten ip_tot_len sanity check for reassembled packets which
        was more loose than intended.

        Add another sanity check for fragment ip_tot_len; even though
        it be redundant, add for completeness.

v1->v2: Few fixes, improvements and cleanups.

Darrell Ball (9):
  dp-packet: Add const qualifiers for checksum apis.
  flow: Enhance parse_ipv6_ext_hdrs.
  tests: Add missed local stack checks.
  conntrack: Reword conntrack_execute() description.
  Userspace datapath: Add fragmentation handling.
  ipf: Add command to disable fragmentation handling.
  ipf: Add set minimum fragment size command.
  ipf: Add set maximum fragments supported command.
  ipf: Add fragmentation status reporting.

 NEWS                             |   12 +
 include/sparse/netinet/ip6.h     |    1 +
 lib/automake.mk                  |    2 +
 lib/conntrack.c                  |   17 +-
 lib/ct-dpif.c                    |   69 ++
 lib/ct-dpif.h                    |   13 +
 lib/dp-packet.h                  |    8 +-
 lib/dpctl.c                      |  227 ++++++
 lib/dpctl.man                    |   38 +
 lib/dpif-netdev.c                |   83 +++
 lib/dpif-netlink.c               |    7 +
 lib/dpif-provider.h              |   25 +-
 lib/flow.c                       |   31 +-
 lib/flow.h                       |    3 +-
 lib/ipf.c                        | 1413 ++++++++++++++++++++++++++++++++++++++
 lib/ipf.h                        |   76 ++
 tests/system-kmod-macros.at      |   42 +-
 tests/system-traffic.at          |   52 +-
 tests/system-userspace-macros.at |  148 +++-
 19 files changed, 2204 insertions(+), 63 deletions(-)
 create mode 100644 lib/ipf.c
 create mode 100644 lib/ipf.h

-- 
1.9.1



More information about the dev mailing list