[ovs-dev] [PATCH] xlate: use const struct in6_addr in linklocal check

Ben Pfaff blp at ovn.org
Tue Jul 10 16:19:48 UTC 2018


On Tue, Jul 10, 2018 at 09:34:38AM -0400, Aaron Conole wrote:
> Commit 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to
> terminate_native_tunnel()") introduced a call to
> IN6_IS_ADDR_MC_LINKLOCAL() when checking neighbor discovery.
> 
> The call to this assumes that the argument may be a const uint8_t *.
> According to The Open Group Base Specifications Issue 7, 2018:
> 
>     macro is of type int and takes a single argument of
>     type const struct in6_addr *
> 
> The GNU implementation allows a bit of flexibility, by internally
> casting the argument.  However, other implementations (such as OS X)
> more rigidly implement the standard and fail with errors like:
> 
>     error: member reference base type 'const uint8_t'
>            (aka 'const unsigned char') is not a structure or union
> 
> Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to terminate_native_tunnel()")
> Cc: Zoltan Balogh <zoltan.balogh.eth at gmail.com>
> Cc: Jan Scheurich <jan.scheurich at ericsson.com>
> Signed-off-by: Aaron Conole <aconole at redhat.com>

Thanks, applied to master.


More information about the dev mailing list