[ovs-dev] [PATCH v3 1/1] netdev-vport: reject concomitant incompatible tunnels

Ben Pfaff blp at ovn.org
Tue Jul 10 21:45:27 UTC 2018


On Fri, Jun 01, 2018 at 07:03:55PM +0200, Eelco Chaudron wrote:
> This patch will make sure VXLAN tunnels with and without the group
> based policy (GBP) option enabled can not coexist on the same
> destination UDP port.
> 
> In theory, VXLAN tunnel with and without GBP enables can be
> multiplexed on the same UDP port as long as different VNI's are
> used. However currently OVS does not support this, hence this patch to
> check for this condition.
> 
> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>

Thanks for the patch, and sorry that I'm so slow.

Does this support the case where, in a single database transaction, a
GBP VXLAN tunnel is removed and a non-GBP VXLAN tunnel is created that
would otherwise interfere with one another (and the converse case)?  If
so, could that be included in the test?

"sparse" doesn't like the initialization strategy:

../lib/netdev-vport.c:1207:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1211:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1215:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1219:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1220:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1221:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1225:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1229:9: error: Using plain integer as NULL pointer
../lib/netdev-vport.c:1261:13: error: Using plain integer as NULL pointer

Thanks,

Ben.


More information about the dev mailing list