[ovs-dev] [PATCH] ovn-nbctl: Fix compilation warnings.

Stokes, Ian ian.stokes at intel.com
Wed Jul 11 09:13:15 UTC 2018


> On Tue, Jul 10, 2018 at 07:46:55PM +0100, Ian Stokes wrote:
> > This commit fixes 'maybe-uninitialized' warnings for pointers in
> > various functions in ovn-nbctl when compiling with gcc 6.3.1 and -
> Werror.
> > Pointers to structs nbrec_logical_switch, nbrec_logical_switch_port,
> > nbrec_logical_router and nbrec_logical_router_port are now initialized
> > to NULL where required.
> >
> > Cc: Justin Pettit <jpettit at ovn.org>
> > Cc: Venkata Anil <vkommadi at redhat.com>
> > Fixes: 31114af758c7 ("ovn-nbctl: Update logical router port
> > commands.")
> > Fixes: 80f408f4cffb ("ovn: Use Logical_Switch_Port in NB.")
> > Fixes: 36f232bca2db ("ovn: l3ha, CLI for logical router port gateway
> >                       chassis")
> > Signed-off-by: Ian Stokes <ian.stokes at intel.com>
> 
> Does the following patch also fix the problem?
> https://patchwork.ozlabs.org/patch/942179/

Thanks for the patch Ben, yes it resolves the problem also. Your patch is simpler/better than what I have proposed so let's stick with yours :).

Ian



More information about the dev mailing list