[ovs-dev] [PATCH 05/14] datapath-windows: Cleanup Gre.c

Shashank Ram rams at vmware.com
Wed Jul 11 22:55:39 UTC 2018



On 07/09/2018 06:40 AM, Alin Gabriel Serdean wrote:
> Do not assign an initial value to ` status`, it will be assigned
> later on.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> ---
>   datapath-windows/ovsext/Gre.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/datapath-windows/ovsext/Gre.c b/datapath-windows/ovsext/Gre.c
> index afdd5abe3..c95d089e4 100644
> --- a/datapath-windows/ovsext/Gre.c
> +++ b/datapath-windows/ovsext/Gre.c
> @@ -318,7 +318,7 @@ OvsDecapGre(POVS_SWITCH_CONTEXT switchContext,
>       UINT32 headRoom = 0;
>       UINT32 maxGreLen;
>       PUINT8 bufferStart;
> -    NDIS_STATUS status = NDIS_STATUS_SUCCESS;
> +    NDIS_STATUS status;
>       PCHAR tempBuf = NULL;
>       OVS_PACKET_HDR_INFO layers;
>   

Do you mind merging the patches that make a common change as this into a 
single patch? I don't see a benefit to keep these separate.


More information about the dev mailing list