[ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

[Roi Dayan]

On 11/07/2018 16:24, Simon Horman wrote:
> On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote:
>> Added new types to the flow dump filter, and allowed multiple filter
>> types to be passed at once, as a comma separated list. The new types
>> added are:
>>  * tc - specifies flows handled by the tc dp
>>  * non-offloaded - specifies flows not offloaded to the HW
>>  * all - specifies flows of all types
>>
>> The type list is now fully parsed by the dpctl, and a new struct was
>> added to dpif which enables dpctl to define which types of dumps to
>> provide, rather than passing the type string and having dpif parse it.
>>
>> Signed-off-by: Gavi Teitz <gavi at mellanox.com>
>> Acked-by: Roi Dayan <roid at mellanox.com>
> 
> Hi,
> 
> this looks good to me. However, I wonder if it should wait until after the
> v2.10 soft-freeze is over.
> 

it could. 
currently offload unit tests in the repo fail and needs an update
though they cannot be fixed because they use veth and test dump
using type=offloaded to verify rules in tc.
this patch adds the possibility again to check rules in tc.
then we can fix the offload unit tests.
besides this nothing is really broken.