[ovs-dev] [ovs-dev, 12 of 15] ovn-nbctl: Initial support for daemon mode.

Aaron Conole aconole at redhat.com
Thu Jul 12 11:34:40 UTC 2018


Jakub Sitnicki <jkbs at redhat.com> writes:

> On Wed, 11 Jul 2018 16:04:32 -0400
> 0-day Robot <robot at bytheb.org> wrote:
>
>> Bleep bloop.  Greetings Jakub Sitnicki, I am a robot and I have
>> tried out your patch.
>> Thanks for your contribution.
>> 
>> I encountered some error that I wasn't expecting.  See the details below.
>> 
>> 
>> checkpatch:
>> WARNING: Line is 82 characters long (recommended limit is 79)
>> #80 FILE: ovn/utilities/ovn-nbctl.8.xml:1023:
>>     <xi:include href="lib/daemon.xml"
>> xmlns:xi="http://www.w3.org/2003/XInclude"/>
>> 
>> Lines checked: 409, Warnings: 1, Errors: 0
>
> This was intentional. The convention in this XML doc seems to be that
> includes are not wrapped to fit in the length limit.

Maybe it makes sense to extend checkpatch for the xml case?  Not sure -
in some other xml files we do try to keep the line-length convention.


More information about the dev mailing list