[ovs-dev] [ovs-dev, 3 of 4] flow: Refactor some of VLAN helper functions

0-day Robot robot at bytheb.org
Mon Jul 16 10:59:24 UTC 2018


Bleep bloop.  Greetings Jianbo Liu, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


build:
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/netdev-tc-offloads.lo -MD -MP -MF lib/.deps/netdev-tc-offloads.Tpo -c lib/netdev-tc-offloads.c -o lib/netdev-tc-offloads.o
lib/netdev-tc-offloads.c: In function 'parse_tc_flower_to_match':
lib/netdev-tc-offloads.c:434:9: error: too few arguments to function 'match_set_dl_vlan'
         match_set_dl_vlan(match, htons(key->vlan_id));
         ^
In file included from lib/netdev-tc-offloads.c:26:0:
./include/openvswitch/match.h:166:6: note: declared here
 void match_set_dl_vlan(struct match *, ovs_be16, int id);
      ^
lib/netdev-tc-offloads.c:436:9: error: too many arguments to function 'match_set_dl_type'
         match_set_dl_type(match, key->encap_eth_type, 0);
         ^
In file included from lib/netdev-tc-offloads.c:26:0:
./include/openvswitch/match.h:156:6: note: declared here
 void match_set_dl_type(struct match *, ovs_be16);
      ^
lib/netdev-tc-offloads.c: At top level:
cc1: error: unrecognized command line option "-Wno-null-pointer-arithmetic" [-Werror]
cc1: all warnings being treated as errors
make[2]: *** [lib/netdev-tc-offloads.lo] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list