[ovs-dev] [ovs-dev, v2, 2 of 4] ipsec: reintroduce IPsec support for tunneling

[0-day Robot]

Bleep bloop.  Greetings Qiuyu Xiao, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Too many signoffs; are you missing Co-authored-by lines?
WARNING: Line is 80 characters long (recommended limit is 79)
#118 FILE: Documentation/howto/ipsec.rst:45:
ovs-monitor-ipsec configures IKE daemom accordingly based on the tunnel options.

WARNING: Line is 80 characters long (recommended limit is 79)
#137 FILE: Documentation/howto/ipsec.rst:64:
   self-signed.  Refer to the ovs-pki(8) man page for more information regarding

WARNING: Line is 81 characters long (recommended limit is 79)
#138 FILE: Documentation/howto/ipsec.rst:65:
   certificate and key generation. Then, copy the remote certificate to the local

WARNING: Line is 81 characters long (recommended limit is 79)
#148 FILE: Documentation/howto/ipsec.rst:75:
                                     options:remote_cert=/path/to/remote_cert.pem

WARNING: Line is 85 characters long (recommended limit is 79)
#425 FILE: debian/openvswitch-ipsec.init:27:
# Description:       The ovs-monitor-ipsec script provides support for encrypting GRE

WARNING: Line is 80 characters long (recommended limit is 79)
#577 FILE: debian/openvswitch-ipsec.init:179:
        log_warning_msg "Reloading $NAME daemon: not implemented, as the daemon"

WARNING: Line is 80 characters long (recommended limit is 79)
#582 FILE: debian/openvswitch-ipsec.init:184:
        echo "Usage: $N {start|stop|force-stop|restart|force-reload|status}" >&2

WARNING: Line is 81 characters long (recommended limit is 79)
#771 FILE: ipsec/ovs-monitor-ipsec:154:
            if len(a) >= 4 and a[0] == "sel" and a[1] == "src" and a[3] == "dst":

WARNING: Line is 80 characters long (recommended limit is 79)
#828 FILE: ipsec/ovs-monitor-ipsec:211:
        self.CHARON_CONF = strongswan_root_prefix + "/etc/strongswan.d/ovs.conf"

WARNING: Line is 83 characters long (recommended limit is 79)
#908 FILE: ipsec/ovs-monitor-ipsec:291:
                                (tunnel.conf["local_ip"], tunnel.conf["remote_ip"],

WARNING: Line is 83 characters long (recommended limit is 79)
#913 FILE: ipsec/ovs-monitor-ipsec:296:
                                (tunnel.conf["local_ip"], tunnel.conf["remote_ip"],

WARNING: Line is 83 characters long (recommended limit is 79)
#916 FILE: ipsec/ovs-monitor-ipsec:299:
                auth_section = self.auth_tmpl["pki_remote"].substitute(tunnel.conf)

WARNING: Line has trailing whitespace
#1068 FILE: ipsec/ovs-monitor-ipsec:451:
            self.secrets_file.write('%s %s : PSK "%s"\n' % 

WARNING: Line is 80 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#1069 FILE: ipsec/ovs-monitor-ipsec:452:
                            (tunnel.conf["local_ip"], tunnel.conf["remote_ip"], 

WARNING: Line is 81 characters long (recommended limit is 79)
#1131 FILE: ipsec/ovs-monitor-ipsec:514:
            # In a corner case, LibreSwan daemon restarts for some reason and the

WARNING: Line is 81 characters long (recommended limit is 79)
#1484 FILE: ipsec/ovs-monitor-ipsec:867:
                                the supported daemon (StrongSwan or LibreSwan).")

WARNING: Line is 82 characters long (recommended limit is 79)
#1582 FILE: ipsec/ovs-monitor-ipsec:965:
        """This function reads all configuration from OVSDB that ovs-monitor-ipsec

WARNING: Line is 82 characters long (recommended limit is 79)
#1739 FILE: ipsec/ovs-monitor-ipsec:1122:
    seqno = idl.change_seqno  # Sequence number when OVSDB was processed last time

Lines checked: 1945, Warnings: 19, Errors: 1


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot