[ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable code and goto labels

Alin Serdean aserdean at cloudbasesolutions.com
Thu Jul 19 18:36:58 UTC 2018


> Subiect: Re: [ovs-dev] [PATCH 2/2] Datapath: Fix ovs_vport_init unreachable
> code and goto labels
> 
> I think the correct fix may be as follows, do you mind rechecking it?
> Thanks.
> 
> diff --git a/datapath/vport.c b/datapath/vport.c index
> 02f6b56d3243..fcf0fea0a245 100644
> --- a/datapath/vport.c
> +++ b/datapath/vport.c
> @@ -93,7 +93,6 @@ int ovs_vport_init(void)
>                 goto err_stt;
> 
>         return 0;
> -       ovs_stt_cleanup_module();
>  err_stt:
>         vxlan_cleanup_module();
>  err_vxlan:
> 
Thanks for the suggestion. I folded in the changes and sent out a v2:
https://patchwork.ozlabs.org/patch/946556/
Do you mind giving a Signed-off? 


More information about the dev mailing list