[ovs-dev] [PATCH v2 2/2] Datapath: Remove ovs_vport_init unreachable code

Yifeng Sun pkusunyifeng at gmail.com
Thu Jul 19 18:39:57 UTC 2018


Thanks for the work.

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>

On Thu, Jul 19, 2018 at 11:34 AM, Alin Gabriel Serdean <aserdean at ovn.org>
wrote:

> The line "ovs_stt_cleanup_module();" was unreachable.
> Found using static analysis tools.
>
> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> Co-authored-by: Yifeng Sun <pkusunyifeng at gmail.com>
> ---
> v2: Remove unreachable code only.
> ---
>  datapath/vport.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/datapath/vport.c b/datapath/vport.c
> index 28ddb865c..55f40255b 100644
> --- a/datapath/vport.c
> +++ b/datapath/vport.c
> @@ -97,7 +97,6 @@ int ovs_vport_init(void)
>                 goto err_stt;
>
>         return 0;
> -       ovs_stt_cleanup_module();
>  err_stt:
>         vxlan_cleanup_module();
>  err_vxlan:
> --
> 2.16.1.windows.1
>
>


More information about the dev mailing list