[ovs-dev] [PATCH] compat: Initialize IPv4 reassembly secret timer

Yi-Hung Wei yihung.wei at gmail.com
Mon Jul 23 16:22:35 UTC 2018


>>> --- a/datapath/linux/compat/ip_fragment.c
>>> +++ b/datapath/linux/compat/ip_fragment.c
>>> @@ -812,6 +812,9 @@ int __init rpl_ipfrag_init(void)
>>>   #ifdef HAVE_INET_FRAGS_WITH_FRAGS_WORK
>>>          ip4_frags.frags_cache_name = ip_frag_cache_name;
>>>   #endif
>>> +#if RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8,0)
>>> +       ip4_frags.secret_interval = 10 * 60 * HZ;
>>> +#endif
>>
>> This is a great catch!  Looks like we remove the secret_interval in
>> net-next commit
>> e3a57d18b061 ("inet: frag: remove periodic secret rebuild timer")
>> But somehow RHEL kernel still retain this field, and the
>> secret_interval was set to 10 * 60 * HZ.
>>
>> I would recommend to set 'secret_interval' by grepping this filed in
>> 'struct inet_frags' rather than by kernel version. So that if RHEL 8
>> kernel still have this field, your fix will apply.
>
>
> That's a good point to raise.
>
> My thinking was to specifically call it out for RHEL 7 because it hasn't
> been in the kernel since 3.16
> and this bug is RHEL 7 specific. That's a long way back and I'm sure it will
> not be there in
> the RHEL 8 kernel.  This makes it clear that it is only for RHEL 7 and
> nothing else.
>
> However, if you and others feel strongly about it I don't mind making the
> change.

I do not have a strong opinion no this. I think current solution also work.

Thanks,

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list