[ovs-dev] [PATCH 10/11] ovn-nbctl: Remove pointless "return; " at ends of functions.

Ben Pfaff blp at ovn.org
Tue Jul 24 16:18:02 UTC 2018


On Tue, Jul 24, 2018 at 03:20:25PM +0200, Jakub Sitnicki wrote:
> On Mon, 23 Jul 2018 15:38:55 -0700
> Ben Pfaff <blp at ovn.org> wrote:
> 
> > On Tue, Jul 17, 2018 at 03:34:14PM +0200, Jakub Sitnicki wrote:
> > > Fix fall-out from applying a semantic patch that converts ctl_fatal()
> > > calls to use ctl_error().
> > > 
> > > Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>  
> > 
> > Oh, you fixed that up later ;-).  Ha, I'll revert it to your way
> > instead, never mind.
> 
> Yes, I've decided to do fix-ups separately so that the
> Coccinelle-generated patches could be reviewed based on the semantic
> patch. Not sure if that worked out fine or just created confusion.

I thought that these two were OK, but I'd probably insist on squashing
if one of the fix-ups could cause bisection problems.


More information about the dev mailing list