[ovs-dev] [PATCH] ovs-tcpdump: Fix incompatibilities with python3

Ben Pfaff blp at ovn.org
Tue Jul 24 23:01:36 UTC 2018


On Tue, Jul 24, 2018 at 06:35:13PM +0200, Timothy Redaelli wrote:
> Opening a file with 'rw' in Python3 returns an error, moreover using 'rw' in
> Python2 is wrong too since it opens the file using O_RDONLY and not by using
> O_RDWR.
> 
> This commit fixes it by using the low-level os.open function with O_RDWR
> as suggested by the Linux kernel (tuntap.txt) documentation.
> 
> This commit fixes also some usual bytes vs string incompatibilities.
> 
> Tested on Python 2.7.15 and Python 3.6.5
> 
> Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>

Applied to master, thanks!


More information about the dev mailing list