[ovs-dev] [PATCH] dpctl: Expand the flow dump type filter

[Ben Pfaff]

On Wed, Jul 25, 2018 at 06:17:15PM +0200, Simon Horman wrote:
> On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote:
> > 
> > 
> > On 11/07/2018 16:24, Simon Horman wrote:
> > > On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote:
> > >> Added new types to the flow dump filter, and allowed multiple filter
> > >> types to be passed at once, as a comma separated list. The new types
> > >> added are:
> > >>  * tc - specifies flows handled by the tc dp
> > >>  * non-offloaded - specifies flows not offloaded to the HW
> > >>  * all - specifies flows of all types
> > >>
> > >> The type list is now fully parsed by the dpctl, and a new struct was
> > >> added to dpif which enables dpctl to define which types of dumps to
> > >> provide, rather than passing the type string and having dpif parse it.
> > >>
> > >> Signed-off-by: Gavi Teitz <gavi at mellanox.com>
> > >> Acked-by: Roi Dayan <roid at mellanox.com>
> > > 
> > > Hi,
> > > 
> > > this looks good to me. However, I wonder if it should wait until after the
> > > v2.10 soft-freeze is over.
> > > 
> > 
> > it could. 
> > currently offload unit tests in the repo fail and needs an update
> > though they cannot be fixed because they use veth and test dump
> > using type=offloaded to verify rules in tc.
> > this patch adds the possibility again to check rules in tc.
> > then we can fix the offload unit tests.
> > besides this nothing is really broken.
> 
> I believe the freeze is now over, I have applied this patch to the master
> branch.

It breaks the build.  Clang:

    ../lib/dpif-netdev.c:6812:5: error: incompatible pointer types initializing 'struct dpif_flow_dump *(*)(const struct dpif *, bool, struct dpif_flow_dump_types *)' with an expression of type 'struct dpif_flow_dump *(const struct dpif *, bool, char *)' [-Werror,-Wincompatible-pointer-types]

Sparse:

    ../lib/tc.c:817:37: error: incorrect type in assignment (different base types)
    ../lib/tc.c:817:37:    expected restricted ovs_be16 [usertype] vlan_push_tpid
    ../lib/tc.c:817:37:    got unsigned short
    ../lib/tc.c:1522:54: error: incorrect type in argument 2 (different base types)
    ../lib/tc.c:1522:54:    expected unsigned short [unsigned] [usertype] tpid
    ../lib/tc.c:1522:54:    got restricted ovs_be16 [usertype] vlan_push_tpid

    ../lib/dpif-netdev.c:6812:5: error: incorrect type in initializer (incompatible argument 3 (different base types))
    ../lib/dpif-netdev.c:6812:5:    expected struct dpif_flow_dump *( *flow_dump_create )( ... )
    ../lib/dpif-netdev.c:6812:5:    got struct dpif_flow_dump *( static [toplevel] *<noident> )( ... )