[ovs-dev] [PATCH] dpif-netdev: compatible function type

Ben Pfaff blp at ovn.org
Wed Jul 25 18:35:49 UTC 2018


On Wed, Jul 25, 2018 at 02:22:31PM -0400, Aaron Conole wrote:
> The dpif_provder flow_dump_create function signature was changed, but
> the netdev dpif was not updated along with it.  This generated a build
> error with the following warnings:
> 
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/dpif-netdev.lo -MD -MP -MF lib/.deps/dpif-netdev.Tpo -c lib/dpif-netdev.c -o lib/dpif-netdev.o
> lib/dpif-netdev.c:6812:5: error: initialization from incompatible pointer type [-Werror]
>      dpif_netdev_flow_dump_create,
>      ^
> lib/dpif-netdev.c:6812:5: error: (near initialization for 'dpif_netdev_class.flow_dump_create') [-Werror]
> 
> Fixes: ab15e70eb587 ("dpctl: Expand the flow dump type filter")
> Cc: Gavi Teitz <gavi at mellanox.com>
> Cc: Roi Dayan <roid at mellanox.com>
> Cc: Simon Horman <simon.horman at netronome.com>
> Signed-off-by: Aaron Conole <aconole at redhat.com>

Thanks, applied to master.


More information about the dev mailing list